From df74984c520cb7a5141e7a46c5c1c71bf31355b7 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Wed, 28 Sep 2022 14:33:22 +1000 Subject: Stricter checking for nsholder.c Add the -Wextra -pedantic and -std=c99 flags when compiling the nsholder test helper to get extra compiler checks, like we already use for the main source code. While we're there, fix some %d (signed) printf descriptors being used for unsigned values (uid_t and gid_t). Pointed out by cppcheck. Signed-off-by: David Gibson Signed-off-by: Stefano Brivio --- test/Makefile | 2 +- test/nsholder.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/Makefile b/test/Makefile index 08f0c2d..91498ff 100644 --- a/test/Makefile +++ b/test/Makefile @@ -63,7 +63,7 @@ LOCAL_ASSETS = mbuto.img QEMU_EFI.fd \ ASSETS = $(DOWNLOAD_ASSETS) $(LOCAL_ASSETS) -CFLAGS = -Wall -Werror +CFLAGS = -Wall -Werror -Wextra -pedantic -std=c99 assets: $(ASSETS) diff --git a/test/nsholder.c b/test/nsholder.c index aac901b..010a051 100644 --- a/test/nsholder.c +++ b/test/nsholder.c @@ -53,7 +53,7 @@ static void hold(int fd, const struct sockaddr_un *addr) if (rc < 0) die("listen(): %s\n", strerror(errno)); - printf("nsholder: local PID=%d local UID=%d local GID=%d\n", + printf("nsholder: local PID=%d local UID=%u local GID=%u\n", getpid(), getuid(), getgid()); do { int afd = accept(fd, NULL, NULL); -- cgit v1.2.3