From 73a4a6b7cd4570f77c8ebb1cf6808b13d62b4db0 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Thu, 21 Oct 2021 17:34:42 +0200 Subject: ndp: Don't send a DNS search list if we don't have a list of DNS servers This is not explicitly forbidden, but it confuses the ISC's DHCP client, and doesn't make sense anyway. Signed-off-by: Stefano Brivio --- ndp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ndp.c b/ndp.c index 92abbe9..ec6b5ef 100644 --- a/ndp.c +++ b/ndp.c @@ -140,10 +140,11 @@ int ndp(struct ctx *c, struct ethhdr *eh, size_t len) memcpy(p, &c->dns6[i], 16); /* address */ p += 16; } + + for (n = 0; *c->dns_search[n].n; n++) + dns_s_len += strlen(c->dns_search[n].n) + 2; } - for (n = 0; *c->dns_search[n].n; n++) - dns_s_len += strlen(c->dns_search[n].n) + 2; if (dns_s_len) { *p++ = 31; /* DNSSL */ *p++ = (len + 8 - 1) / 8 + 1; /* length */ -- cgit v1.2.3