From 3f2e7098acef1027682212eb0e9895e7f6cb3af3 Mon Sep 17 00:00:00 2001 From: Stefano Brivio Date: Sun, 1 May 2022 06:55:49 +0200 Subject: netlink: In nl_addr() and nl_route(), don't return before set request Fixes: 22ed4467a413 ("treewide: Unchecked return value from library, CWE-252") Signed-off-by: Stefano Brivio --- netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/netlink.c b/netlink.c index 78c1186..66a95e4 100644 --- a/netlink.c +++ b/netlink.c @@ -328,7 +328,7 @@ void nl_route(int ns, unsigned int ifi, sa_family_t af, void *gw) req.nlh.nlmsg_flags |= NLM_F_DUMP; } - if (set || (n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0) + if ((n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0 || set) return; nh = (struct nlmsghdr *)buf; @@ -435,7 +435,7 @@ void nl_addr(int ns, unsigned int ifi, sa_family_t af, req.nlh.nlmsg_flags |= NLM_F_DUMP; } - if (set || (n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0) + if ((n = nl_req(ns, buf, &req, req.nlh.nlmsg_len)) < 0 || set) return; nh = (struct nlmsghdr *)buf; -- cgit v1.2.3