From 07cb07de4c6e69beb9d15f9a0156e55c4ca6161a Mon Sep 17 00:00:00 2001 From: Volker Diels-Grabsch Date: Tue, 16 Sep 2025 21:21:13 +0200 Subject: Introduce constant MAC_BROADCAST Signed-off-by: Volker Diels-Grabsch Reviewed-by: David Gibson Signed-off-by: Stefano Brivio --- tap.c | 2 +- util.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/tap.c b/tap.c index cf862ef..50e1a88 100644 --- a/tap.c +++ b/tap.c @@ -1511,7 +1511,7 @@ void tap_backend_init(struct ctx *c) * sends us packets. Use the broadcast address so that our * first packets will reach it. */ - memset(&c->guest_mac, 0xff, sizeof(c->guest_mac)); + memcpy(&c->guest_mac, MAC_BROADCAST, sizeof(c->guest_mac)); break; } diff --git a/util.h b/util.h index 2a8c38f..22eaac5 100644 --- a/util.h +++ b/util.h @@ -97,6 +97,8 @@ void abort_with_msg(const char *fmt, ...) #define FD_PROTO(x, proto) \ (IN_INTERVAL(c->proto.fd_min, c->proto.fd_max, (x))) +#define MAC_BROADCAST \ + ((uint8_t [ETH_ALEN]){ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }) #define MAC_ZERO ((uint8_t [ETH_ALEN]){ 0 }) #define MAC_IS_ZERO(addr) (!memcmp((addr), MAC_ZERO, ETH_ALEN)) -- cgit v1.2.3