aboutgitcodebugslistschat
path: root/test/tcp/passt_in_ns
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2022-06-24 12:17:29 +1000
committerStefano Brivio <sbrivio@redhat.com>2022-07-06 08:10:55 +0200
commitdab2c6ee1f308af001dd4f57a13ec16e765f930b (patch)
tree4ba6045db5093293362c1697a3410574ea2aad7c /test/tcp/passt_in_ns
parent20c418f1f911f8a6c75b3d83fdab52ee4840640d (diff)
downloadpasst-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar.gz
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar.bz2
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar.lz
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar.xz
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.tar.zst
passt-dab2c6ee1f308af001dd4f57a13ec16e765f930b.zip
Add cleaner line-by-line reading primitives
Two places in passt need to read files line by line (one parsing resolv.conf, the other parsing /proc/net/*. They can't use fgets() because in glibc that can allocate memory. Instead they use an implementation line_read() in util.c. This has some problems: * It has two completely separate modes of operation, one buffering and one not, the relation between these and how they're activated is subtle and confusing * At least in non-buffered mode, it will mishandle an empty line, folding them onto the start of the next non-empty line * In non-buffered mode it will use lseek() which prevents using this on non-regular files (we don't need that at present, but it's a surprising limitation) * It has a lot of difficult to read pointer mangling Add a new cleaner implementation of allocation-free line-by-line reading in lineread.c. This one always buffers, using a state structure to keep track of what we need. This is larger than I'd like, but it turns out handling all the edge cases of line-by-line reading in C is surprisingly hard. This just adds the code, subsequent patches will change the existing users of line_read() to the new implementation. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'test/tcp/passt_in_ns')
0 files changed, 0 insertions, 0 deletions