diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2022-08-23 16:31:51 +1000 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2022-08-24 18:01:48 +0200 |
commit | 60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c (patch) | |
tree | 00595ce3495820fd01f1ea4f0833bc247a2845d3 /test/tcp/passt_in_ns | |
parent | 42a60735e1a1ec9dd72b09bc9c926a4dbc0d8545 (diff) | |
download | passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar.gz passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar.bz2 passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar.lz passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar.xz passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.tar.zst passt-60ffc5b6cb85e6fc7707f6b1d918c93b77a92f2c.zip |
Don't unnecessarily avoid CLOEXEC flags2022_08_24.60ffc5b
There are several places in the passt code where we have lint overrides
because we're not adding CLOEXEC flags to open or other operations.
Comments suggest this is because it's before we fork() into the background
but we'll need those file descriptors after we're in the background.
However, as the name suggests CLOEXEC closes on exec(), not on fork(). The
only place we exec() is either super early invoke the avx2 version of the
binary, or when we start a shell in pasta mode, which certainly *doesn't*
require the fds in question.
Add the CLOEXEC flag in those places, and remove the lint overrides.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'test/tcp/passt_in_ns')
0 files changed, 0 insertions, 0 deletions