diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2022-09-13 14:35:23 +1000 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-09-13 11:12:41 +0200 |
| commit | 1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c (patch) | |
| tree | 81c5f4d49f8081cf39f4255bc5f06c2f15da8a0b /test/lib | |
| parent | c71a5e8528f7278a645ed3dab2c7e813dcb7d8bf (diff) | |
| download | passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar.gz passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar.bz2 passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar.lz passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar.xz passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.tar.zst passt-1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c.zip | |
test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives
Instead of using the 'temp' and 'tempdir' DSL directives to create
temporary files, use fixed paths relative to __STATEDIR__. This has two
advantages:
1) The files are automatically cleaned up if the tests fail (and even if
that doesn't work they're easier to clean up manuall)
2) When debugging tests it's easier to figure out which of the temporary
files are relevant to whatever's going wrong
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'test/lib')
| -rwxr-xr-x | test/lib/test | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/test/lib/test b/test/lib/test index 3dbae0b..3ad178f 100755 --- a/test/lib/test +++ b/test/lib/test @@ -99,16 +99,6 @@ test_one_line() { IFS= eval TEST_ONE_DEF_$TEST_ONE_in_def= IFS="${__ifs}" ;; - "tempdir") - __tmpdir="$(mktemp -d)" - TEST_ONE_subs="$(list_add_pair "${TEST_ONE_subs}" "__${__arg}__" "${__tmpdir}")" - TEST_ONE_dirclean="$(list_add "${TEST_ONE_dirclean}" "${__tmpdir}")" - ;; - "temp") - __tmpfile="$(mktemp)" - TEST_ONE_subs="$(list_add_pair "${TEST_ONE_subs}" "__${__arg}__" "${__tmpfile}")" - TEST_ONE_dirclean="$(list_add "${TEST_ONE_dirclean}" "${__tmpfile}")" - ;; "test") [ ${TEST_ONE_perf_nok} -eq 0 ] || TEST_ONE_nok=1 [ ${TEST_ONE_nok} -eq 1 ] && status_test_fail |