diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2023-11-30 13:02:17 +1100 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2023-12-04 09:51:22 +0100 |
| commit | 788d2fe3ce7231b520b139712d721e9d481b49ea (patch) | |
| tree | 22fbb187e7de0ead43a92d006d11c03d73870306 /tcp_splice.h | |
| parent | ecea8d36ff921fc27e2dc8270380d824458cda24 (diff) | |
| download | passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar.gz passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar.bz2 passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar.lz passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar.xz passt-788d2fe3ce7231b520b139712d721e9d481b49ea.tar.zst passt-788d2fe3ce7231b520b139712d721e9d481b49ea.zip | |
tcp_splice: Use unsigned to represent side
Currently, we use 'int' values to represent the "side" of a connection,
which must always be 0 or 1. This turns out to be dangerous.
In some cases we're going to want to put the side into a 1-bit bitfield.
However, if that bitfield has type 'int', when we copy it out to a regular
'int' variable, it will be sign-extended and so have values 0 and -1,
instead of 0 and 1.
To avoid this, always use unsigned variables for the side.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tcp_splice.h')
0 files changed, 0 insertions, 0 deletions