diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2024-06-05 10:42:41 +1000 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-06-05 21:14:06 +0200 |
commit | 7cb2088835784e101f7305445126b85b9c93a759 (patch) | |
tree | aa6b0e297ed5c1607d2f77aa23f62af4c726f795 /tcp_splice.c | |
parent | e651197b5c80c125326605b96357bac24c804487 (diff) | |
download | passt-7cb2088835784e101f7305445126b85b9c93a759.tar passt-7cb2088835784e101f7305445126b85b9c93a759.tar.gz passt-7cb2088835784e101f7305445126b85b9c93a759.tar.bz2 passt-7cb2088835784e101f7305445126b85b9c93a759.tar.lz passt-7cb2088835784e101f7305445126b85b9c93a759.tar.xz passt-7cb2088835784e101f7305445126b85b9c93a759.tar.zst passt-7cb2088835784e101f7305445126b85b9c93a759.zip |
conf: Don't print usage via the logging subsystem
The message from usage() when given invalid options, or the -h / --help
option is currently printed by many calls to the info() function, also
used for runtime logging of informational messages.
That isn't useful: the usage message should always go to the terminal
(stdout or stderr), never syslog or a logfile. It should never be
filtered by priority. Really the only thing using the common logging
functions does is give more opportunities for something to go wrong.
Replace all the info() calls with direct fprintf() calls. This does mean
manually adding "\n" to each message. A little messy, but worth it for the
simplicity in other dimensions. While we're there make much heavier use
of single strings containing multiple lines of output text. That reduces
the number of fprintf calls, reducing visual clutter and making it easier
to see what the output will look like from the source.
Link: https://bugs.passt.top/show_bug.cgi?id=90
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tcp_splice.c')
0 files changed, 0 insertions, 0 deletions