aboutgitcodebugslistschat
path: root/tcp.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2023-03-21 14:55:00 +1100
committerStefano Brivio <sbrivio@redhat.com>2023-03-21 16:38:44 +0100
commit89d1494974d5677ace7ed4973cc2aa9b2f94ec92 (patch)
tree8181857472c4de1380d3b9bccc0a67b8c0d3f93b /tcp.c
parent34ade90957ddc5086cc17dc1af47ca640aa650e5 (diff)
downloadpasst-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar.gz
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar.bz2
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar.lz
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar.xz
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.tar.zst
passt-89d1494974d5677ace7ed4973cc2aa9b2f94ec92.zip
Fix false positive if cppcheck doesn't give a false positive
da46fdac "tcp: Suppress knownConditionTrueFalse cppcheck false positive" introduced a suppression to work around a cppcheck bug causing a false positive warning. However, the suppression will itself cause a spurious unmatchedSuppression warning if used with a version of cppcheck from before the bug was introduced. That includes the packaged version of cppcheck in Fedora. Suppress the unmatchedSuppression as well. Fixes: da46fdac3605 ("tcp: Suppress knownConditionTrueFalse cppcheck false positive") Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tcp.c')
-rw-r--r--tcp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tcp.c b/tcp.c
index 3bfcb1c..c9c76d7 100644
--- a/tcp.c
+++ b/tcp.c
@@ -1822,7 +1822,7 @@ static void tcp_clamp_window(const struct ctx *c, struct tcp_tap_conn *conn,
*
* drop this suppression once that's resolved.
*/
- /* cppcheck-suppress knownConditionTrueFalse */
+ /* cppcheck-suppress [knownConditionTrueFalse, unmatchedSuppression] */
if ((wnd > prev_scaled && wnd * 99 / 100 < prev_scaled) ||
(wnd < prev_scaled && wnd * 101 / 100 > prev_scaled))
return;