diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2024-01-16 11:50:31 +1100 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-01-22 23:34:55 +0100 |
commit | 17bbab1c97516048fdcc6c2e6c8efc524e56e71e (patch) | |
tree | 97129289111d1a0991c6a268cc8084d0f96d9837 /tcp.c | |
parent | 00c6eb6b68d9bc5abeabcd167882f5ef17f28143 (diff) | |
download | passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar.gz passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar.bz2 passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar.lz passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar.xz passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.tar.zst passt-17bbab1c97516048fdcc6c2e6c8efc524e56e71e.zip |
flow: Make flow_table.h #include the protocol specific headers it needs
flow_table.h, the lower level flow header relies on having the struct
definitions for every protocol specific flow type - so far that means
tcp_conn.h. It doesn't include it itself, so tcp_conn.h must be included
before flow_table.h.
That's ok for now, but as we use the flow table for more things,
flow_table.h will need the structs for all of them, which means the
protocol specific .c files would need to include tcp_conn.h _and_ the
equivalents for every other flow type before flow_table.h every time,
which is weird.
So, although we *mostly* lean towards the include style where .c files need
to handle the include dependencies, in this case it makes more sense to
have flow_table.h include all the protocol specific headers it needs.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tcp.c')
-rw-r--r-- | tcp.c | 1 |
1 files changed, 0 insertions, 1 deletions
@@ -298,7 +298,6 @@ #include "inany.h" #include "flow.h" -#include "tcp_conn.h" #include "flow_table.h" /* Sides of a flow as we use them in "tap" connections */ |