diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2022-04-05 12:33:31 +0200 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-04-07 11:44:35 +0200 |
| commit | ceddcac74a6eafae8d959adcbfee17d4cae2c3a8 (patch) | |
| tree | bd7c719bfc30063c3b8ee1f69e227e4176793ff4 /tap.c | |
| parent | e46f67f15230e07ef35f4f54126a47ef5a60238b (diff) | |
| download | passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar.gz passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar.bz2 passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar.lz passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar.xz passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.tar.zst passt-ceddcac74a6eafae8d959adcbfee17d4cae2c3a8.zip | |
conf, tap: False "Buffer not null terminated" positives, CWE-170
Those strings are actually guaranteed to be NULL-terminated. Reported
by Coverity.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tap.c')
| -rw-r--r-- | tap.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -798,9 +798,9 @@ static void tap_sock_unix_init(struct ctx *c) char *path = addr.sun_path; if (*c->sock_path) - strncpy(path, c->sock_path, UNIX_PATH_MAX); + memcpy(path, c->sock_path, UNIX_PATH_MAX); else - snprintf(path, UNIX_PATH_MAX, UNIX_SOCK_PATH, i); + snprintf(path, UNIX_PATH_MAX - 1, UNIX_SOCK_PATH, i); ex = socket(AF_UNIX, SOCK_STREAM | SOCK_NONBLOCK, 0); if (ex < 0) { @@ -899,7 +899,7 @@ static int tap_ns_tun(void *arg) int flags = O_RDWR | O_NONBLOCK | O_CLOEXEC; struct ctx *c = (struct ctx *)arg; - strncpy(ifr.ifr_name, c->pasta_ifn, IFNAMSIZ); + memcpy(ifr.ifr_name, c->pasta_ifn, IFNAMSIZ); if (ns_enter(c) || (tun_ns_fd = open("/dev/net/tun", flags)) < 0 || |