diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2022-10-19 11:43:45 +1100 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-10-19 03:34:26 +0200 |
| commit | 67ab6171729cfcf7867cbb92a2099d88d86f6e6b (patch) | |
| tree | f4422311d378d56a79409b16aaa1343afc71c8cb /tap.c | |
| parent | 7abd2b0d727b4dad0f92d8c3130931d023e58514 (diff) | |
| download | passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar.gz passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar.bz2 passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar.lz passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar.xz passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.tar.zst passt-67ab6171729cfcf7867cbb92a2099d88d86f6e6b.zip | |
Add csum_icmp4() helper for calculating ICMP checksums
Although tap_ip_send() is currently the only place calculating ICMP
checksums, create a helper function for symmetry with ICMPv6. For
future flexibility it allows the ICMPv6 header and payload to be in
separate buffers.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'tap.c')
| -rw-r--r-- | tap.c | 4 |
1 files changed, 1 insertions, 3 deletions
@@ -148,9 +148,7 @@ void tap_ip_send(const struct ctx *c, const struct in6_addr *src, uint8_t proto, uh->check = 0; } else if (iph->protocol == IPPROTO_ICMP) { struct icmphdr *ih = (struct icmphdr *)(iph + 1); - - ih->checksum = 0; - ih->checksum = csum_unaligned(ih, len, 0); + csum_icmp4(ih, ih + 1, len - sizeof(*ih)); } if (tap_send(c, buf, len + sizeof(*iph) + sizeof(*eh), 1) < 0) |