diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2022-10-26 17:55:53 +0200 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-10-27 00:18:21 +0200 |
| commit | f21204494064e28e9f0bb20f71a6071bead0d0e8 (patch) | |
| tree | 7875bd50fd6264206d8e6c8ffeb444052c32300a /tap.c | |
| parent | b062ee47d1d587ad15106d09aec4d1710f256cd6 (diff) | |
| download | passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar.gz passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar.bz2 passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar.lz passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar.xz passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.tar.zst passt-f21204494064e28e9f0bb20f71a6071bead0d0e8.zip | |
icmp: Don't discard first reply sequence for a given echo ID2022_10_26.f212044
In pasta mode, ICMP and ICMPv6 echo sockets relay back to us any
reply we send: we're on the same host as the target, after all. We
discard them by comparing the last sequence we sent with the sequence
we receive.
However, on the first reply for a given identifier, the sequence
might be zero, depending on the implementation of ping(8): we need
another value to indicate we haven't sent any sequence number, yet.
Use -1 as initialiser in the echo identifier map.
This is visible with Busybox's ping, and was reported by Paul on the
integration at https://github.com/containers/podman/pull/16141, with:
$ podman run --net=pasta alpine ping -c 2 192.168.188.1
...where only the second reply would be routed back.
Reported-by: Paul Holzinger <pholzing@redhat.com>
Fixes: 33482d5bf293 ("passt: Add PASTA mode, major rework")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'tap.c')
0 files changed, 0 insertions, 0 deletions