diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2021-10-19 17:28:18 +0200 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2021-10-20 08:29:30 +0200 |
commit | 1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc (patch) | |
tree | 13ee3b6da82e5eb53a89bb881ccf3a7092dab9fe /pasta.c | |
parent | 087b5f4dbb9e3f767a8afbb6c1001c509965940b (diff) | |
download | passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar.gz passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar.bz2 passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar.lz passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar.xz passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.tar.zst passt-1a563a0cbd4926d0dfe9065a4fcd8771c5b292cc.zip |
passt: Address gcc 11 warnings
A mix of unchecked return values, a missing permission mask for
open(2) with O_CREAT, and some false positives from
-Wstringop-overflow and -Wmaybe-uninitialized.
Reported-by: Martin Hauke <mardnh@gmx.de>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'pasta.c')
-rw-r--r-- | pasta.c | 15 |
1 files changed, 10 insertions, 5 deletions
@@ -184,7 +184,8 @@ void pasta_start_ns(struct ctx *c) snprintf(proc_path, PATH_MAX, "/proc/%i/ns/net", pasta_child_pid); - readlink(proc_path, pasta_child_ns, PATH_MAX); + if (readlink(proc_path, pasta_child_ns, PATH_MAX) < 0) + warn("Cannot read link to ns, won't clean up on exit"); return; } @@ -198,20 +199,24 @@ void pasta_start_ns(struct ctx *c) snprintf(buf, BUFSIZ, "%u %u %u", 0, euid, 1); fd = open("/proc/self/uid_map", O_WRONLY); - write(fd, buf, strlen(buf)); + if (write(fd, buf, strlen(buf)) < 0) + warn("Cannot set uid_map in namespace"); close(fd); fd = open("/proc/self/setgroups", O_WRONLY); - write(fd, "deny", sizeof("deny")); + if (write(fd, "deny", sizeof("deny"))) + warn("Cannot write to setgroups in namespace"); close(fd); fd = open("/proc/self/gid_map", O_WRONLY); - write(fd, buf, strlen(buf)); + if (write(fd, buf, strlen(buf)) < 0) + warn("Cannot set gid_map in namespace"); close(fd); } fd = open("/proc/sys/net/ipv4/ping_group_range", O_WRONLY); - write(fd, "0 0", strlen("0 0")); + if (write(fd, "0 0", strlen("0 0")) < 0) + warn("Cannot set ping_group_range, ICMP requests might fail"); close(fd); shell = getenv("SHELL") ? getenv("SHELL") : "/bin/sh"; |