diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2024-03-08 00:12:19 +0100 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-03-12 01:50:48 +0100 |
commit | 860d2764dd7ce683c0cfeec1ed60dee0c1f2b443 (patch) | |
tree | fdab2c87e32de9bceb014ce88dd2078fcad5a497 /passt.c | |
parent | 4779dfe12fd0aa6d94f9029e430d55f60f4c581f (diff) | |
download | passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar.gz passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar.bz2 passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar.lz passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar.xz passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.tar.zst passt-860d2764dd7ce683c0cfeec1ed60dee0c1f2b443.zip |
conf: Don't warn if nameservers were found, but won't be advertised
Starting from commit 3a2afde87dd1 ("conf, udp: Drop mostly duplicated
dns_send arrays, rename related fields"), we won't add to c->ip4.dns
and c->ip6.dns nameservers that can't be used by the guest or
container, and we won't advertise them.
However, the fact that we don't advertise any nameserver doesn't mean
that we didn't find any, and we should warn only if we couldn't find
any.
This is particularly relevant in case both --dns-forward and
--no-map-gw are passed, and a single loopback address is listed in
/etc/resolv.conf: we'll forward queries directed to the address
specified by --dns-forward to the loopback address we found, we
won't advertise that address, so we shouldn't warn: this is a
perfectly legitimate usage.
Reported-by: Paul Holzinger <pholzing@redhat.com>
Link: https://github.com/containers/podman/issues/19213
Fixes: 3a2afde87dd1 ("conf, udp: Drop mostly duplicated dns_send arrays, rename related fields")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Paul Holzinger <pholzing@redhat.com>
Diffstat (limited to 'passt.c')
0 files changed, 0 insertions, 0 deletions