diff options
author | David Gibson <david@gibson.dropbear.id.au> | 2022-06-14 15:12:21 +1000 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2022-06-18 09:06:00 +0200 |
commit | 08007d0b25a8175bf6f663fd12b25e4e4eea4d17 (patch) | |
tree | 07423d7a49bec2f220848ef7d6a40516d0a11ef0 /lineread.c | |
parent | 465712721efac593beac8a1879bf2f11ed121d12 (diff) | |
download | passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar.gz passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar.bz2 passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar.lz passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar.xz passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.tar.zst passt-08007d0b25a8175bf6f663fd12b25e4e4eea4d17.zip |
Makefile: Avoid using wildcard sources
The passt/pasta Makefile makes fairly heavy use of GNU make's $(wildcard)
function to locate the sources and headers to build. Using wildcards for
the things to compile is usually a bad idea though: if somehow you end up
with a .c or .h file in your tree you didn't expect it can misbuild in an
exceedingly confusing way. In particular this can sometimes happen if
switching between releases / branches where files have been added or
removed without 100% cleaning the tree.
It also makes life a bit complicated if building multiple different
binaries in the same tree: we already have some rather awkward
$(filter-out) constructions to avoid including qrap.c in the passt build.
Replace use of $(wildcard) with the more idiomatic approach of defining
variables listing all the relevant source files then using that throughout.
In the rule for seccomp.h there was also a bare "*.c" which caused make to
always rebuild that target. Fix that as well.
Similarly, seccomp.sh uses a wildcard to locate the sources, which is
unwise for the same reasons. Make it take the sources to examine on the
command line instead, and have the Makefile pass them in from the same
variables.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'lineread.c')
0 files changed, 0 insertions, 0 deletions