aboutgitcodebugslistschat
path: root/icmp_flow.h
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2024-05-21 15:57:03 +1000
committerStefano Brivio <sbrivio@redhat.com>2024-05-22 23:20:52 +0200
commit7a832a8a0edbdd5a705c1fe03fca0790a535ab11 (patch)
tree408f32fadc34b75ea9e7e166a5ba91880a4a1d73 /icmp_flow.h
parent1a20370b364ada675882e6a70d05b6e81418d64f (diff)
downloadpasst-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar.gz
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar.bz2
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar.lz
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar.xz
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.tar.zst
passt-7a832a8a0edbdd5a705c1fe03fca0790a535ab11.zip
flow: Properly type callbacks to protocol specific handlers
The flow dispatches deferred and timer handling for flows centrally, but needs to call into protocol specific code for the handling of individual flows. Currently this passes a general union flow *. It makes more sense to pass the specific relevant flow type structure. That brings the check on the flow type adjacent to casting to the union variant which it tags. Arguably, this is a slight abstraction violation since it involves the generic flow code using protocol specific types. It's already calling into protocol specific functions, so I don't think this really makes any difference. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'icmp_flow.h')
-rw-r--r--icmp_flow.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/icmp_flow.h b/icmp_flow.h
index 5a2eed9..c9847ea 100644
--- a/icmp_flow.h
+++ b/icmp_flow.h
@@ -25,7 +25,7 @@ struct icmp_ping_flow {
uint16_t id;
};
-bool icmp_ping_timer(const struct ctx *c, union flow *flow,
+bool icmp_ping_timer(const struct ctx *c, const struct icmp_ping_flow *pingf,
const struct timespec *now);
#endif /* ICMP_FLOW_H */