aboutgitcodebugslistschat
path: root/icmp.c
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2022-05-01 06:36:34 +0200
committerStefano Brivio <sbrivio@redhat.com>2022-05-01 07:19:05 +0200
commit3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf (patch)
treeb6f895672d7a4db2d64c5faa3cea39245f0326f9 /icmp.c
parentdf69be379e6d8b8b1aab2d00b858b89acfde7ab8 (diff)
downloadpasst-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar.gz
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar.bz2
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar.lz
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar.xz
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.tar.zst
passt-3c6ae625101aee6ddf94e0fd85ce3a9c9067c3bf.zip
conf, tcp, udp: Allow address specification for forwarded ports
This feature is available in slirp4netns but was missing in passt and pasta. Given that we don't do dynamic memory allocation, we need to bind sockets while parsing port configuration. This means we need to process all other options first, as they might affect addressing and IP version support. It also implies a minor rework of how TCP and UDP implementations bind sockets. Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'icmp.c')
-rw-r--r--icmp.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/icmp.c b/icmp.c
index 8abc94b..2da8b58 100644
--- a/icmp.c
+++ b/icmp.c
@@ -168,7 +168,8 @@ int icmp_tap_handler(const struct ctx *c, int af, const void *addr,
iref.icmp.id = id = ntohs(ih->un.echo.id);
if ((s = icmp_id_map[V4][id].sock) <= 0) {
- s = sock_l4(c, AF_INET, IPPROTO_ICMP, id, 0, iref.u32);
+ s = sock_l4(c, AF_INET, IPPROTO_ICMP, NULL, id,
+ iref.u32);
if (s < 0)
goto fail_sock;
if (s > SOCKET_MAX) {
@@ -205,7 +206,7 @@ int icmp_tap_handler(const struct ctx *c, int af, const void *addr,
iref.icmp.id = id = ntohs(ih->icmp6_identifier);
if ((s = icmp_id_map[V6][id].sock) <= 0) {
- s = sock_l4(c, AF_INET6, IPPROTO_ICMPV6, id, 0,
+ s = sock_l4(c, AF_INET6, IPPROTO_ICMPV6, NULL, id,
iref.u32);
if (s < 0)
goto fail_sock;