aboutgitcodebugslistschat
path: root/contrib
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2024-06-07 11:55:24 +1000
committerStefano Brivio <sbrivio@redhat.com>2024-06-07 20:44:44 +0200
commitec416fdcc4b607583e87bbdd35b48f6eb9dc633f (patch)
tree77a0d22977daa67534a4672804033bc4b923bc82 /contrib
parent3f63743a65bf3d987615774cdab0a9cb1006ae47 (diff)
downloadpasst-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar.gz
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar.bz2
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar.lz
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar.xz
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.tar.zst
passt-ec416fdcc4b607583e87bbdd35b48f6eb9dc633f.zip
tcp, flow: Fix some error paths which didn't clean up flows properly
Flow table entries need to be fully initialised before returning to the main epoll loop. Commit 0060acd1 ("flow: Clarify and enforce flow state transitions") now enforces that: once a flow is allocated we must either cancel it, or activate it before returning to the main loop, or we will hit an ASSERT(). Some error paths in tcp_conn_from_tap() weren't correctly updated for this requirement - we can exit with a flow entry incompletely initialised. Correct that by cancelling the flows in those situations. I don't have enough information to be certain if this is the cause for podman bug 22925, but it plausibly could be. Fixes: 0060acd11b19 ("flow: Clarify and enforce flow state transitions") Link: https://github.com/containers/podman/issues/22925 Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions