diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2024-10-25 00:10:36 +0200 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2024-10-30 12:37:31 +0100 |
| commit | 59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3 (patch) | |
| tree | 38745c05d3b8c5836380133c33f1e60d2a0e0847 /conf.c | |
| parent | 134b4d58b409013d9f231aac1d4ba69f7835da7c (diff) | |
| download | passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar.gz passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar.bz2 passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar.lz passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar.xz passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.tar.zst passt-59fe34ee36368bb28c8298b1a1bfad5d0d9f47a3.zip | |
treewide: Suppress clang-tidy warning if we already use O_CLOEXEC
In pcap_init(), we should always open the packet capture file with
O_CLOEXEC, even if we're not running in foreground: O_CLOEXEC means
close-on-exec, not close-on-fork.
In logfile_init() and pidfile_open(), the fact that we pass a third
'mode' argument to open() seems to confuse the android-cloexec-open
checker in LLVM versions from 16 to 19 (at least).
The checker is suggesting to add O_CLOEXEC to 'mode', and not in
'flags', where we already have it.
Add a suppression for clang-tidy and a comment, and avoid repeating
those three times by adding a new helper, output_file_open().
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Diffstat (limited to 'conf.c')
| -rw-r--r-- | conf.c | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -1194,7 +1194,11 @@ static void conf_open_files(struct ctx *c) if (c->mode != MODE_PASTA && c->fd_tap == -1) c->fd_tap_listen = tap_sock_unix_open(c->sock_path); - c->pidfile_fd = pidfile_open(c->pidfile); + if (*c->pidfile) { + c->pidfile_fd = output_file_open(c->pidfile, O_WRONLY); + if (c->pidfile_fd < 0) + die_perror("Couldn't open PID file %s", c->pidfile); + } } /** |