passt: Fix build with gcc 7, use std=c99, enable some more Clang checkers

Unions and structs, you all have names now.

Take the chance to enable bugprone-reserved-identifier,
cert-dcl37-c, and cert-dcl51-cpp checkers in clang-tidy.

Provide a ffsl() weak declaration using gcc built-in.

Start reordering includes, but that's not enough for the
llvm-include-order checker yet.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

1 files changed, 9 insertions, 9 deletions

diff --git a/arp.c b/arp.c
index 89e4019..2f3e3ac 100644
--- a/arp.c
+++ b/arp.c
@@ -12,24 +12,24 @@
  * Author: Stefano Brivio <sbrivio@redhat.com>
  */
 
-#include <stdio.h>
+#include <arpa/inet.h>
+#include <limits.h>
+#include <net/if.h>
+#include <net/if_arp.h>
+#include <netinet/if_ether.h>
 #include <stddef.h>
 #include <stdint.h>
+#include <stdio.h>
 #include <unistd.h>
 #include <string.h>
-#include <linux/if_ether.h>
-#include <linux/ip.h>
+
 #include <linux/ipv6.h>
-#include <linux/udp.h>
-#include <net/if.h>
-#include <net/if_arp.h>
-#include <arpa/inet.h>
 
 #include "util.h"
-#include "passt.h"
+#include "arp.h"
 #include "dhcp.h"
+#include "passt.h"
 #include "tap.h"
-#include "arp.h"
 
 /**
  * arp() - Check if this is an ARP message, reply as needed