diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2023-02-27 03:44:25 +0100 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2023-02-27 18:55:39 +0100 |
| commit | fb05a713789fd9c20d0432f023ce26f3c5b94251 (patch) | |
| tree | 21913b22b83273972b6b2b70b852265e9d635358 | |
| parent | 26a0e4d6ee17fa174a401d8e8d9a4c189f11f258 (diff) | |
| download | passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar.gz passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar.bz2 passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar.lz passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar.xz passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.tar.zst passt-fb05a713789fd9c20d0432f023ce26f3c5b94251.zip | |
doc/demo: Fix and suppress ShellCheck warnings
ShellCheck reports (SC2034) that __qemu_arch is not used. Use it,
and silence the resulting SC2086 warning as we want word splitting on
options we pass with it.
While at it, silence SC2317 warnings for commands in cleanup() that
appear to be unreachable: cleanup() is only called as trap.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
| -rwxr-xr-x | doc/demo.sh | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/doc/demo.sh b/doc/demo.sh index ed71ffb..5b05ddf 100755 --- a/doc/demo.sh +++ b/doc/demo.sh @@ -110,6 +110,7 @@ next() { } # cleanup() - Terminate pasta and passt, clean up, restore TTY settings +# shellcheck disable=SC2317 cleanup() { [ -f "${DEMO_DIR}/pasta.pid" ] && kill "$(cat "${DEMO_DIR}/pasta.pid")" [ -f "${DEMO_DIR}/passt.pid" ] && kill "$(cat "${DEMO_DIR}/passt.pid")" @@ -223,7 +224,8 @@ into_ns() { echo "Use ^C to terminate it." next - cmd qrap 5 qemu-system-x86_64 -M pc,accel=kvm:tcg \ + # shellcheck disable=SC2086 + cmd qrap 5 ${__qemu_arch} \ -smp "$(nproc)" -m 1024 \ -nographic -serial stdio -nodefaults -no-reboot -vga none \ -initrd "${DEMO_DIR}/demo.img" \ |