diff options
author | Stefano Brivio <sbrivio@redhat.com> | 2024-02-15 23:41:59 +0100 |
---|---|---|
committer | Stefano Brivio <sbrivio@redhat.com> | 2024-02-16 08:47:14 +0100 |
commit | 338b6321ac0db2fbcbfccd99d2625f3b6da777da (patch) | |
tree | fdeadfaea303399a256fc6a11688375bf3829cf7 | |
parent | 8f3f8e190c43fc6a3adc7912aaa262e86f9d0748 (diff) | |
download | passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar.gz passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar.bz2 passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar.lz passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar.xz passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.tar.zst passt-338b6321ac0db2fbcbfccd99d2625f3b6da777da.zip |
conf: No routable interface for IPv4 or IPv6 is informational, not a warning
...Podman users might get confused by the fact that if we can't
find a default route for a given IP version, we'll report that as a
warning message and possibly just before actual error messages.
However, a lack of routable interface for IPv4 or IPv6 can be a
normal circumstance: don't warn about it, just state that as
informational message, if those are displayed (they're not in
non-error paths in Podman, for example).
While at it, make it clear that we're disabling IPv4 or IPv6 if
there's no routable interface for the corresponding IP version.
Reported-by: Paul Holzinger <pholzing@redhat.com>
Link: https://github.com/containers/podman/pull/21563#issuecomment-1937024642
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r-- | conf.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -565,7 +565,7 @@ static unsigned int conf_ip4(unsigned int ifi, ifi = nl_get_ext_if(nl_sock, AF_INET); if (!ifi) { - warn("No external routable interface for IPv4"); + info("No routable interface for IPv4: IPv4 is disabled"); return 0; } @@ -637,7 +637,7 @@ static unsigned int conf_ip6(unsigned int ifi, ifi = nl_get_ext_if(nl_sock, AF_INET6); if (!ifi) { - warn("No external routable interface for IPv6"); + info("No routable interface for IPv6: IPv6 is disabled"); return 0; } |