diff options
| author | Stefano Brivio <sbrivio@redhat.com> | 2023-02-21 18:03:49 +0000 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2023-02-21 19:12:37 +0100 |
| commit | 01801b131f21f126b341f0db069727d6f9bd8d2e (patch) | |
| tree | 01f45a287c63686b2b93bc7976ed6f38ab6ded7d | |
| parent | 49024476309df1f6f32f34c40e793592687c9f26 (diff) | |
| download | passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar.gz passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar.bz2 passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar.lz passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar.xz passt-01801b131f21f126b341f0db069727d6f9bd8d2e.tar.zst passt-01801b131f21f126b341f0db069727d6f9bd8d2e.zip | |
selinux: Switch to a more reasonable model for PID and socket files
Instead of restricting PID files to /var/run/passt.pid, which is a
single file and unlikely to be used, use the user_tmp_t type which
should cover any reasonable need.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
| -rw-r--r-- | contrib/selinux/passt.fc | 1 | ||||
| -rw-r--r-- | contrib/selinux/passt.te | 11 |
2 files changed, 7 insertions, 5 deletions
diff --git a/contrib/selinux/passt.fc b/contrib/selinux/passt.fc index 4638200..286c868 100644 --- a/contrib/selinux/passt.fc +++ b/contrib/selinux/passt.fc @@ -10,4 +10,3 @@ /usr/bin/passt(\.*)? system_u:object_r:passt_exec_t:s0 /tmp/passt\.pcap system_u:object_r:passt_log_t:s0 -/var/run/passt\.pid system_u:object_r:passt_pid_t:s0 diff --git a/contrib/selinux/passt.te b/contrib/selinux/passt.te index 1f45fcd..12a4288 100644 --- a/contrib/selinux/passt.te +++ b/contrib/selinux/passt.te @@ -19,6 +19,7 @@ require { type user_home_dir_t; type fs_t; type tmp_t; + type user_tmp_t; type tmpfs_t; type root_t; @@ -59,8 +60,6 @@ files_type(passt_exec_t); init_daemon_domain(passt_t, passt_exec_t) type passt_log_t; logging_log_file(passt_log_t); -type passt_pid_t; -files_pid_file(passt_pid_t); type passt_etc_t; files_config_file(passt_etc_t); @@ -83,8 +82,8 @@ allow passt_t tmp_t:dir { add_name mounton remove_name write }; allow passt_t tmpfs_t:filesystem mount; allow passt_t fs_t:filesystem unmount; -manage_files_pattern(passt_t, passt_pid_t, passt_pid_t) -files_pid_filetrans(passt_t, passt_pid_t, file) +manage_files_pattern(passt_t, user_tmp_t, user_tmp_t) +files_pid_filetrans(passt_t, user_tmp_t, file) allow passt_t console_device_t:chr_file { open write getattr ioctl }; allow passt_t user_devpts_t:chr_file { getattr read write ioctl }; @@ -110,3 +109,7 @@ corenet_udp_bind_generic_node(passt_t) allow passt_t passt_port_t:udp_socket { name_bind }; allow passt_t node_t:icmp_socket { name_bind node_bind }; allow passt_t self:icmp_socket { bind create setopt read write }; + +allow passt_t user_tmp_t:dir { add_name write }; +allow passt_t user_tmp_t:file { create open }; +allow passt_t user_tmp_t:sock_file { create read write unlink }; |