aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2024-05-14 00:57:57 +1000
committerStefano Brivio <sbrivio@redhat.com>2024-05-13 23:02:05 +0200
commit29bd08ff0fe09d47155eda3c3191513c3b4f381b (patch)
tree9cff9503504182b246270af2d0b47b0984a6c84b
parent26c71db332fa916fab6faef9dd9833f3d5749ca6 (diff)
downloadpasst-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar.gz
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar.bz2
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar.lz
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar.xz
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.tar.zst
passt-29bd08ff0fe09d47155eda3c3191513c3b4f381b.zip
conf: Fix clang-tidy warning about using an undefined enum value
In conf() we temporarily set the forwarding mode variables to 0 - an invalid value, so that we can check later if they've been set by the intervening logic. clang-tidy 18.1.1 in Fedora 40 now complains about this. Satisfy it by giving an name in the enum to the 0 value. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--conf.c4
-rw-r--r--fwd.h1
2 files changed, 3 insertions, 2 deletions
diff --git a/conf.c b/conf.c
index 3f30725..21d46fe 100644
--- a/conf.c
+++ b/conf.c
@@ -1203,8 +1203,8 @@ void conf(struct ctx *c, int argc, char **argv)
optstring = "dqfel:hs:F:p:P:m:a:n:M:g:i:o:D:S:461t:u:";
}
- c->tcp.fwd_in.mode = c->tcp.fwd_out.mode = 0;
- c->udp.fwd_in.f.mode = c->udp.fwd_out.f.mode = 0;
+ c->tcp.fwd_in.mode = c->tcp.fwd_out.mode = FWD_UNSET;
+ c->udp.fwd_in.f.mode = c->udp.fwd_out.f.mode = FWD_UNSET;
do {
name = getopt_long(argc, argv, optstring, options, NULL);
diff --git a/fwd.h b/fwd.h
index 23281d9..41645d7 100644
--- a/fwd.h
+++ b/fwd.h
@@ -11,6 +11,7 @@
#define NUM_PORTS (1U << 16)
enum fwd_ports_mode {
+ FWD_UNSET = 0,
FWD_SPEC = 1,
FWD_NONE,
FWD_AUTO,