diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2022-09-28 14:33:25 +1000 |
|---|---|---|
| committer | Stefano Brivio <sbrivio@redhat.com> | 2022-09-29 12:22:17 +0200 |
| commit | 6aca100469838a030542283013589d99a002d10d (patch) | |
| tree | 8741206d9e76baf9503a8b5841b18ac1c4d19309 | |
| parent | fb15259205c006149fc0bedbf4ef135e53c4268e (diff) | |
| download | passt-6aca100469838a030542283013589d99a002d10d.tar passt-6aca100469838a030542283013589d99a002d10d.tar.gz passt-6aca100469838a030542283013589d99a002d10d.tar.bz2 passt-6aca100469838a030542283013589d99a002d10d.tar.lz passt-6aca100469838a030542283013589d99a002d10d.tar.xz passt-6aca100469838a030542283013589d99a002d10d.tar.zst passt-6aca100469838a030542283013589d99a002d10d.zip | |
cppcheck: Use inline suppressions for qrap.c
qrap.c uses several old-fashioned functions that cppcheck complains about.
Since it's headed for obselesence anyway, just suppress these rather than
attempting to modernize the code.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
| -rw-r--r-- | Makefile | 3 | ||||
| -rw-r--r-- | qrap.c | 3 |
2 files changed, 4 insertions, 2 deletions
@@ -287,7 +287,7 @@ cppcheck: $(SRCS) $(HEADERS) --suppress=va_list_usedBeforeStarted:util.c \ --suppress=unusedFunction \ --suppress=knownConditionTrueFalse:conf.c \ - --suppress=strtokCalled:conf.c --suppress=strtokCalled:qrap.c \ + --suppress=strtokCalled:conf.c \ --suppress=localtimeCalled:pcap.c \ --suppress=unusedStructMember:pcap.c \ --suppress=unusedStructMember:dhcp.c \ @@ -295,7 +295,6 @@ cppcheck: $(SRCS) $(HEADERS) --suppress=unmatchedSuppression:conf.c \ --suppress=unmatchedSuppression:dhcp.c \ --suppress=unmatchedSuppression:pcap.c \ - --suppress=unmatchedSuppression:qrap.c \ --suppress=unmatchedSuppression:tcp.c \ --suppress=unmatchedSuppression:udp.c \ --suppress=unmatchedSuppression:util.c \ @@ -179,12 +179,14 @@ int main(int argc, char **argv) char env_path[ARG_MAX + 1], *p, command[ARG_MAX]; strncpy(env_path, getenv("PATH"), ARG_MAX); + /* cppcheck-suppress strtokCalled */ p = strtok(env_path, ":"); while (p) { snprintf(command, ARG_MAX, "%s/%s", p, argv[2]); if (!access(command, X_OK)) goto valid_args; + /* cppcheck-suppress strtokCalled */ p = strtok(NULL, ":"); } } @@ -317,6 +319,7 @@ retry: */ if (retry_on_reset && rc == ECONNRESET) { retry_on_reset--; + /* cppcheck-suppress usleepCalled */ usleep(50 * 1000); goto retry; } |