aboutgitcodebugslistschat
diff options
context:
space:
mode:
authorStefano Brivio <sbrivio@redhat.com>2022-03-27 13:41:48 +0200
committerStefano Brivio <sbrivio@redhat.com>2022-03-29 15:35:38 +0200
commit33fc2dece2bc48374f1e8ed8ba14a7f494a565ef (patch)
treec559b8d418e95b0a0e1dd8eac78795b60512b850
parent62c3edd9575cb7dfef0d86392e4b87a4c14d8dee (diff)
downloadpasst-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar.gz
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar.bz2
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar.lz
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar.xz
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.tar.zst
passt-33fc2dece2bc48374f1e8ed8ba14a7f494a565ef.zip
Makefile: Allow implicit test for bugprone-suspicious-string-compare checker
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
-rw-r--r--Makefile5
1 files changed, 1 insertions, 4 deletions
diff --git a/Makefile b/Makefile
index 2cb3735..9f2ec3a 100644
--- a/Makefile
+++ b/Makefile
@@ -187,9 +187,6 @@ pkgs: static
# - cppcoreguidelines-avoid-non-const-global-variables
# TODO: check, fix, and more in general constify wherever possible
#
-# - bugprone-suspicious-string-compare
-# Return value of memcmp(), not really suspicious
-#
# - altera-unroll-loops
# - altera-id-dependent-backward-branch
# TODO: check paths where it might make sense to improve performance
@@ -224,12 +221,12 @@ clang-tidy: $(wildcard *.c) $(wildcard *.h)
-bugprone-narrowing-conversions,\
-cppcoreguidelines-narrowing-conversions,\
-cppcoreguidelines-avoid-non-const-global-variables,\
- -bugprone-suspicious-string-compare,\
-altera-unroll-loops,-altera-id-dependent-backward-branch,\
-bugprone-easily-swappable-parameters,\
-readability-function-cognitive-complexity,\
-altera-struct-pack-align,\
-concurrency-mt-unsafe \
+ -config='{CheckOptions: [{key: bugprone-suspicious-string-compare.WarnOnImplicitComparison, value: "false"}]}' \
--warnings-as-errors=* $(wildcard *.c) -- $(filter-out -pie,$(CFLAGS))
ifeq ($(shell $(CC) -v 2>&1 | grep -c "gcc version"),1)