passt/test, branch 2023_06_25.32660ce

test/nstool: Fix fd leak in accept() loop

2023-05-23T15:06:32+00:00

nstool loops on accept(), but failed to close the accepted socket fds
before continuing on.  So, with repeated commands it would eventually die
with an EMFILE.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test/nstool: Provide useful error if given a path that's too long

2023-05-23T15:06:29+00:00

Normal filesystem paths can be very long (PATH_MAX is around 8k), however
Unix domain sockets can only use relatively short paths (UNIX_PATH_MAX is
108 on Linux).  Currently nstool will simply truncate paths that are too
long, leading to difficult to understand failures.

Make such failures clearer, with an explicit error message if given a path
that's too long.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Enter holder's cwd when changing mount ns with nstool exec

2023-04-07T23:12:12+00:00

If we enter a mount namespace with nstool exec our working directory will
be changed to / in the new mount ns.  This is surprising if we haven't
actually altered any mounts yet in the new ns.  Instead, change the working
directory to match that of the holder process in this situation.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Advertise the holder's cwd (in its mountns) across the socket

2023-04-07T23:12:10+00:00

This is possible useful in nstool info and has further uses for nstool
exec.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Use "nstool exec" to slightly simplify tests

2023-04-07T23:12:08+00:00

Using this, rather than using "nstool info" to get the pid then manually
connecting with nsenter makes things a little simpler.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Initialise ${TRACE} properly

2023-04-07T23:12:05+00:00

Unlike ${DEBUG} we don't initialize ${TRACE} to 0 if not set, which cases
failures when testing it later.  That failure acts as though it is false,
however it emits spurious errors in script.log, which can make it harder to
spot real errors.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Add --keep-caps option to nstool exec

2023-04-07T23:12:03+00:00

This allows you to run commands within a user namespace with the
privilege that comes from owning that userns.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Add nstool exec command to execute commands in an nstool namespace

2023-04-07T23:12:01+00:00

This combines nstool info -pw  with nsenter with various options for
a more convenient and less verbose of entering existing nstool managed
namespaces.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Helpers to iterate through namespace types

2023-04-07T23:11:59+00:00

Will make things a bit less verbose in future.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

nstool: Add magic number to advertized information

2023-04-07T23:11:57+00:00

So that we'll probably give a better error if you point it at something
that's not an nstool hold control socket.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio