passt/test, branch 2022_09_29.06aa26f

Stricter checking for nsholder.c

2022-09-29T10:22:10+00:00

Add the -Wextra -pedantic and -std=c99 flags when compiling the nsholder
test helper to get extra compiler checks, like we already use for the
main source code.

While we're there, fix some %d (signed) printf descriptors being used
for unsigned values (uid_t and gid_t).  Pointed out by cppcheck.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Remove unneccessary pane naming from layout_two_guests

2022-09-29T10:21:23+00:00

This loop goes through and gives a numeric label to each pane, even though
we name the panes properly shortly thereafter.  Looks like a leftover from
some earlier version.  Remove it.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Simplify data handling for transfer tests

2022-09-29T10:21:19+00:00

Many of our tests are based around performing transfers of sample data
across passt/pasta created links.  The data flow here can be a bit
hard to follow since, e.g. we create a file transfer it to the guest,
then transfer it back to the host across several different tests.
This also means that the test cases aren't independent of each other.

Because we don't have the original file available at both ends in some
cases, we compare them by generating md5sums at each end and comparing
them, which is a bit complicated.

Make a number of changes to simplify this:
  1. Pre-generate the sample data files as a test asset, rather than
     building them on the fly during the tests proper
  2. Include the sample data files in the mbuto guest image
  3. Because we have good copies of the original data available in all
     contexts, we can now simply use 'cmp' to check if the transfer
     has worked, avoiding md5sum complications.
  4. Similarly we can always use the original copy of the sample data
     on the send side of each transfer, meaning that the tests become
     more independent of each other.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Use --config-net for namespace setup

2022-09-29T10:21:13+00:00

The setup functions for passt_in_ns and two_guests perform some fairly slow
dhclient calls to configure the network in the namespace before starting
the guest.  This isn't really part of the tests, just necessary for the
operations later.

We can simplify and speed this up a bit by using pasta's '--config-net'
option to configure the networking for us.  As a bonus this means we have
at least a minimal test of the --config-net option itself.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: More robust wait for pasta/passt to be ready

2022-09-29T10:21:07+00:00

When we start passt or pasta, it may take a short time to be ready to
handle packets, especially if running under valgrind.  We have a
number of semi-arbitrary fixed sleeps to account for this.

We can do this more robustly by exploiting the fact that pasta/passt
doesn't write its pidfile until it's ready to go, so if we wait for
the pidfile to be created, we can proceed with confidence.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Remove unnecessary sleeps from shutdown tests

2022-09-29T10:21:01+00:00

These are hangovers from older ways of shutting down the pasta/passt
processes and no longer serve any purpose.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test: Add wait_for() shell helper

2022-09-29T10:20:44+00:00

Add a shell helper function to wait for some command to succeed - typically
a test for something to be done by a background process.  Use it in the
context code which waits for the guest to respond to ssh-over-vsock
connections.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

test/lib: Don't try to write to perf.js when running demos

2022-09-23T22:11:10+00:00

...it doesn't actually exist, and this error now causes the demo to
stop.

Signed-off-by: Stefano Brivio

test/lib: Drop perf_report_append() from perf_report

2022-09-23T22:09:23+00:00

It's not used anymore. While at it, fix the function name in the
comment to perf_report_append_js().

Signed-off-by: Stefano Brivio

test/demo: Avoid using port 5201 on the host

2022-09-23T22:07:18+00:00

That's the default port for iperf3, which also means that it's quite
likely in use on my test machine. Use different port numbers: recycle
the scheme we use in tests for passt and pasta's demo, use 5221-5224
(a bit shorter) for the slirp4netns container in Podman's demo.

Signed-off-by: Stefano Brivio