passt/test, branch 2022_09_24.8978f65

test/lib: Don't try to write to perf.js when running demos

2022-09-23T22:11:10+00:00

...it doesn't actually exist, and this error now causes the demo to
stop.

Signed-off-by: Stefano Brivio

test/lib: Drop perf_report_append() from perf_report

2022-09-23T22:09:23+00:00

It's not used anymore. While at it, fix the function name in the
comment to perf_report_append_js().

Signed-off-by: Stefano Brivio

test/demo: Avoid using port 5201 on the host

2022-09-23T22:07:18+00:00

That's the default port for iperf3, which also means that it's quite
likely in use on my test machine. Use different port numbers: recycle
the scheme we use in tests for passt and pasta's demo, use 5221-5224
(a bit shorter) for the slirp4netns container in Podman's demo.

Signed-off-by: Stefano Brivio

test/demo: Use relative paths to change directories when possible

2022-09-23T22:05:20+00:00

A cd to __STATEDIR__ results in a rather long command, that's not
very readable. Jump between directories using .. and relative paths,
once we're there.

Signed-off-by: Stefano Brivio

test/passt.mbuto: Don't fail on missing guest public key

2022-09-23T15:55:10+00:00

We won't necessarily run mbuto as part of regular tests: it can also
be used for demos or out-of-tree tests.

To keep the profile simple, leave the whole sshd setup there, which
is otherwise harmless, but don't fail if guest-key.pub is missing in
the current directory.

Signed-off-by: Stefano Brivio

test/distro: Update workarounds for Ubuntu 22.04 on s390x

2022-09-23T00:46:24+00:00

If we use dhclient without creating a complete network configuration,
systemd-resolved will stop working after a while, and this sometimes
happens while we're still installing packages.

Disable it, together with systemd-networkd, while taking care of
removing the dhclient hook that prevents overriding /etc/resolv.conf.

While at it, it looks like removing snapd and needrestart actually
takes more time than keeping them: drop that line.

Signed-off-by: Stefano Brivio

test/lib: Wait for DHCPv4 before starting DHCPv6 client in two_guests test

2022-09-23T00:46:24+00:00

I'm not sure why, but dhclient hangs otherwise. This reflects what we
do in the passt_in_ns setup steps.

Eventually, this whole block could go away if we let pasta configure
this network namespace with --config-net.

Signed-off-by: Stefano Brivio

test/perf: Wait for neper servers in guest to be ready before starting client

2022-09-23T00:46:24+00:00

Starting tcp_rr, tcp_crr, udp_rr servers in the guest takes a bit
longer than starting the corresponding clients on the host, and we
end up starting clients before servers unless we add a delay there.

Signed-off-by: Stefano Brivio

test/lib: Wait for kernel to free up ports used by iperf3 before reusing them

2022-09-22T14:54:09+00:00

If we start another server on the same port right away, we might fail
to bind the port. A small delay appears to be needed -- I'm not
entirely sure why at this point.

Signed-off-by: Stefano Brivio

test/lib: Run also iperf3 clients in background, revert to time-based wait

2022-09-22T14:54:09+00:00

Unfortunately, this partially counters recent efforts by David to
speed up these tests, but it looks like iperf3 clients don't reliably
terminate, in some rare cases I couldn't isolate yet.

For the moment being, reintroduce the time-based wait approach, now
using the configurable test duration, and terminate the servers at
the end of it, in case they're stuck. There's no point in keeping
the 'sleep 2' later, so drop that, and while at it, make sure that
the stuck servers have time to flush the JSON output before we use
it.

Signed-off-by: Stefano Brivio