passt/test/pasta, branch 2022_09_24.8978f65 Plug A Simple Socket Transport test: Simpler termination handling for UDP tests 2022-09-13T09:14:29+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T06:37:45+00:00 9fc476af6ebcef88e128fb681631c3a39243f4f2 Because UDP is connectionless we don't have an in-built end-of-stream signal for our connectivity tests. We work around this by explicitly adding an end marker to our sample data and killing the listening end once it is seen. However, socat has some built-in options - null-eof and shut-null - which can be used to signal the end of stream with a zero-length UDP packet. Use these to simplify how the UDP tests are implemented. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
Because UDP is connectionless we don't have an in-built end-of-stream
signal for our connectivity tests.  We work around this by explicitly
adding an end marker to our sample data and killing the listening end once
it is seen.

However, socat has some built-in options - null-eof and shut-null - which
can be used to signal the end of stream with a zero-length UDP packet.
Use these to simplify how the UDP tests are implemented.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives 2022-09-13T09:12:41+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T04:35:23+00:00 1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c Instead of using the 'temp' and 'tempdir' DSL directives to create temporary files, use fixed paths relative to __STATEDIR__. This has two advantages: 1) The files are automatically cleaned up if the tests fail (and even if that doesn't work they're easier to clean up manuall) 2) When debugging tests it's easier to figure out which of the temporary files are relevant to whatever's going wrong Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
Instead of using the 'temp' and 'tempdir' DSL directives to create
temporary files, use fixed paths relative to __STATEDIR__.  This has two
advantages:
  1) The files are automatically cleaned up if the tests fail (and even if
     that doesn't work they're easier to clean up manuall)
  2) When debugging tests it's easier to figure out which of the temporary
     files are relevant to whatever's going wrong

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
test: Don't redundantly regenerate small test file in pasta/tcp 2022-09-13T09:12:41+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T04:35:22+00:00 c71a5e8528f7278a645ed3dab2c7e813dcb7d8bf In what looks like a copy/paste error, pasta/tcp generates its small test file twice. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
In what looks like a copy/paste error, pasta/tcp generates its small test
file twice.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
test: Group tests by mode then protocol, rather than the reverse 2022-09-13T09:12:41+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T04:35:16+00:00 594c2f93716380feb29aeb774ba77704684aa125 For example, passt/dhcp rather than dhcp/passt. This is more consistent with the two_guests and other test groups, and makes some other cleanups simpler. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
For example, passt/dhcp rather than dhcp/passt.  This is more
consistent with the two_guests and other test groups, and makes some
other cleanups simpler.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>