passt/test/passt_in_ns/tcp, branch 2022_09_24.8978f65 Plug A Simple Socket Transport test/passt_in_ns: Consistent sleep commands before starting socat client 2022-09-22T14:53:35+00:00 Stefano Brivio sbrivio@redhat.com 2022-09-16T23:19:29+00:00 fafdda083f91844bfba2b62aa59f03d0ca1a0227 There are some 'sleep 1' commands between starting the socat server and its corresponding client to avoid races due to the server not being ready as we start sending data. However, those don't cover all the cases where we might need them, and in some cases the sleep command actually ended up being before the server even starts. This fixes occasional failures in TCP and UDP simple transfer tests, that became apparent with the new command dispatch mechanism. Signed-off-by: Stefano Brivio <sbrivio@redhat.com> 
There are some 'sleep 1' commands between starting the socat server
and its corresponding client to avoid races due to the server not
being ready as we start sending data.

However, those don't cover all the cases where we might need them,
and in some cases the sleep command actually ended up being before
the server even starts.

This fixes occasional failures in TCP and UDP simple transfer tests,
that became apparent with the new command dispatch mechanism.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
test: Use paths in __STATEDIR__ instead of 'temp' and 'tempdir' directives 2022-09-13T09:12:41+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T04:35:23+00:00 1c36c8d3f8e05d6dbde2842b6c9f78ffc538036c Instead of using the 'temp' and 'tempdir' DSL directives to create temporary files, use fixed paths relative to __STATEDIR__. This has two advantages: 1) The files are automatically cleaned up if the tests fail (and even if that doesn't work they're easier to clean up manuall) 2) When debugging tests it's easier to figure out which of the temporary files are relevant to whatever's going wrong Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
Instead of using the 'temp' and 'tempdir' DSL directives to create
temporary files, use fixed paths relative to __STATEDIR__.  This has two
advantages:
  1) The files are automatically cleaned up if the tests fail (and even if
     that doesn't work they're easier to clean up manuall)
  2) When debugging tests it's easier to figure out which of the temporary
     files are relevant to whatever's going wrong

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
test: Group tests by mode then protocol, rather than the reverse 2022-09-13T09:12:41+00:00 David Gibson david@gibson.dropbear.id.au 2022-09-13T04:35:16+00:00 594c2f93716380feb29aeb774ba77704684aa125 For example, passt/dhcp rather than dhcp/passt. This is more consistent with the two_guests and other test groups, and makes some other cleanups simpler. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> 
For example, passt/dhcp rather than dhcp/passt.  This is more
consistent with the two_guests and other test groups, and makes some
other cleanups simpler.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>