passt/test/lib, branch 2022_09_24.8978f65

test/lib: Don't try to write to perf.js when running demos

2022-09-23T22:11:10+00:00

...it doesn't actually exist, and this error now causes the demo to
stop.

Signed-off-by: Stefano Brivio

test/lib: Drop perf_report_append() from perf_report

2022-09-23T22:09:23+00:00

It's not used anymore. While at it, fix the function name in the
comment to perf_report_append_js().

Signed-off-by: Stefano Brivio

test/lib: Wait for DHCPv4 before starting DHCPv6 client in two_guests test

2022-09-23T00:46:24+00:00

I'm not sure why, but dhclient hangs otherwise. This reflects what we
do in the passt_in_ns setup steps.

Eventually, this whole block could go away if we let pasta configure
this network namespace with --config-net.

Signed-off-by: Stefano Brivio

test/lib: Wait for kernel to free up ports used by iperf3 before reusing them

2022-09-22T14:54:09+00:00

If we start another server on the same port right away, we might fail
to bind the port. A small delay appears to be needed -- I'm not
entirely sure why at this point.

Signed-off-by: Stefano Brivio

test/lib: Run also iperf3 clients in background, revert to time-based wait

2022-09-22T14:54:09+00:00

Unfortunately, this partially counters recent efforts by David to
speed up these tests, but it looks like iperf3 clients don't reliably
terminate, in some rare cases I couldn't isolate yet.

For the moment being, reintroduce the time-based wait approach, now
using the configurable test duration, and terminate the servers at
the end of it, in case they're stuck. There's no point in keeping
the 'sleep 2' later, so drop that, and while at it, make sure that
the stuck servers have time to flush the JSON output before we use
it.

Signed-off-by: Stefano Brivio

test/perf: Disable periodic throughput reports to avoid vhost hang

2022-09-22T14:54:09+00:00

It appears that if we run throughput tests with one-second periodic
reports, the sending side of the vhost channel used for SSH-based
command dispatch occasionally stops working altogether. I haven't
investigated this further, all I see is that output is truncated
at some point, and doesn't resume.

If we use gzip compression (ssh -C) this happens less frequently,
but it still happens, seemingly indicating the issue is probably
related to vhost itself.

Disable periodic reports in iperf3 clients. The -i options were
actually redundant, so remove them from both test files as well as
from test_iperf3().

Signed-off-by: Stefano Brivio

test/lib: Wait on iperf3 clients to be done, then send SIGINT to servers

2022-09-22T14:54:09+00:00

An iperf3 client might fail to send the control message indicating
the end of the test, if the kernel buffer doesn't accept it, and exit
without having sent it, as the control socket is non-blocking. Should
this happen, the server will just wait forever for this message,
instead of terminating.

Restore some of the behaviour that went away with the
"test: Rewrite test_iperf3" patch: instead of waiting on servers to
terminate, wait on the clients. When they are done, wait 2 seconds,
and then send SIGINT to the servers, which make them still write
out the JSON report before terminating.

Signed-off-by: Stefano Brivio

test/lib: Restore IFS while executing directives in def blocks

2022-09-22T14:54:09+00:00

If we don't, guest command dispatch will fail altogether, given that
we use cat(1) on the enter file, which contains spaces.

Signed-off-by: Stefano Brivio

test: term: When checking if status line is a number, hide errors

2022-09-14T18:49:08+00:00

We use the [ "$x" -eq "$x" ] syntax to check if $x is a number. The
behaviour is clearly implied by POSIX, but some shells might actually
report the (intended) error, and dash floods script.log with
"Illegal number" error messages. Hide them.

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test: Move perf.js report file to $LOGDIR/web

2022-09-13T09:12:41+00:00

The tests generate a performance report in $BASEPATH/perf.js and
hooks/pre-push copies it to the website.  To avoid cluttering the working
directory, instead put perf.js in $LOGDIR/web, since it's a test output
artefact.  Update hooks/pre-push to copy from its new location.

Signed-off-by: David Gibson