passt/test/demo, branch 2022_07_14.b86cd00

demo/passt: Bring interface up before starting dhclient in guest

2022-07-14T10:38:42+00:00

...I forgot about one occurrence of this.

Signed-off-by: Stefano Brivio

tests: Explicitly list test files in test/run, remove "onlyfor" support

2022-07-13T23:32:42+00:00

Currently test/run uses wildcards to run all of the tests in a directory.
However, that wildcard list is filtered down by the "onlyfor" directives
in the test files... usually to a single file.

Therefore, just explicitly list the files we *really* want to run for this
test mode.  This makes it easier to see at the top level what tests will
be executed, and to change that list temporarily while debugging specific
failures.

This means the "onlyfor" directive no longer has any purpose, and we can
remove it.  "onlyfor" was also the only used of the $MODE variable, so we
can remove that too.

Signed-off-by: David Gibson

Invoke specific qemu-system-* binaries

2022-07-13T23:32:42+00:00

A lot of tests and examples invoke qemu with the command "kvm".  However,
as far as I can tell, "kvm" being aliased to the appropriate qemu system
binary is Debian specific.  The binary names from qemu upstream -
qemu-system-$ARCH - also aren't universal, but they are more common (they
should be good for both Debian and Fedora at least).

In order to still get KVM acceleration when available, we use the option
"-M accel=kvm:tcg" to tell qemu to try using either KVM or TCG in that
order

A number of the places we invoked "kvm" are expecting specifically an x86
guest, and so it's also safer to explicitly invoke qemu-system-x86_64.

Some others appear to be independent of the target arch (just wanting the
same arch as the host to allow KVM acceleration).  Although I suspect there
may be more subtle x86 specific options in the qemu command lines, attempt
to preserve arch independence by using $(uname -m).

Signed-off-by: David Gibson

test: Add external mbuto profile, drop udhcpc, and switch to it

2022-07-06T06:09:26+00:00

This depends on a future change in mbuto to accept external profile
files. Add a file defining what we need for tests and demos, dropping
udhcpc and script as they're not needed anymore, and switch to it.

Suggested-by: David Gibson 
Signed-off-by: Stefano Brivio

tests: Use nmap-ncat instead of openbsd netcat for pasta tests

2022-06-18T07:05:06+00:00

A number of the testcases use options specific the OpenBSD version of
netcat.  That's available in Debian, but not easily available in Fedora.
Switch the pasta tests to using the nmap version of netcat (a.k.a. ncat).
This is easily available in both Debian and Fedora, and appears to be a
bit more modern and maintained as well.

ncat generally requires explicit listen addresses (which is good for
clarity anywhere).  Its default options appear to remove the need for the
-N and -q options.

Signed-off-by: David Gibson 
[sbrivio: changed one ncat listening address to IPv6 loopback]
Signed-off-by: Stefano Brivio

Tweak dhclient arguments for readability

2022-06-15T07:38:10+00:00

A number of tests and examples use dhclient in both IPv4 and IPv6 modes.
We use "dhclient -6" for IPv6, but usually just "dhclient" for IPv4.  Add
an explicit "-4" argument to make it more clear and explicit.

In addition, when dhclient is run from within pasta it usually won't be
"real" root, and so will not have access to write the default global pid
file.  This results in a mostly harmless but irritating error:
    Can't create /var/run/dhclient.pid: Permission denied
We can avoid that by using the --no-pid flag to dhclient.

Signed-off-by: David Gibson

Don't abbreviate ip(8) arguments in examples and tests

2022-06-15T07:38:10+00:00

ip(8)'s ability to take abbreviated arguments (e.g. "li sh" instead of
"link show") is very handy when using it interactively, but it doesn't make
for very readable scripts and examples when shown that way.

Signed-off-by: David Gibson

demo/pasta: Fix bad sleep directive

2022-05-19T13:24:15+00:00

'sleep' always needs an argument, this was meant to introduce
a 2 seconds delay.

Reviewed-by: David Gibson 
Signed-off-by: Stefano Brivio

tests: Update mbuto git URLs

2022-05-19T13:24:15+00:00

The project is now at mbuto.sh, and git transport is enabled.

Signed-off-by: Stefano Brivio

demo: podman: New port forwarding behaviour for pasta, minor fixes

2022-05-02T21:14:37+00:00

Reflect the recent changes in the Podman adaptation (no port
forwarding by default).

It turns out that by running two iperf3 processes, sometimes
slirp4netns blocks the second connection until the first test is
done, thus doubling the throughput. Use a single process for
slirp4netns with slirp4netns port handling.

Signed-off-by: Stefano Brivio