passt/Makefile, branch bug209

conf: Use new parsing tools to handle -a option

2026-07-04T11:14:25+00:00

The -a command line option can take either an address prefix, or a bare
address.  Current parsing of this is pretty awkward, using the special
purpose helper inany_prefix_pton().  With the new incremental parsing
helpers this can be done more naturally.  Rework it to use them.

This does requiring extending parse_inany() to parse_inany_() which also
reports the format of the address as parse, as opposed to the family of
the resulting address.  This is so that ::ffff:192.0.1.1/112 will be
correctly interpreted the same as 192.0.1.1/16, rather than the
nonsensical 192.0.0.1/112.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

parse: Add helpers for parsing IP addresses

2026-07-04T11:14:09+00:00

parse_ipv[46]() are wrappers around inet_pton() that are more
convenient for use when the IP is part of a longer string, rather than
the entire string.  parse_inany() replaces inany_pton() which again
will become more convenient for strings including IPs that aren't just
an IP.

For now we only have some simple and sometimes awkward use cases,
we'll replace these with more natural uses in future.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

parse: Add helper to parse unsigned integer values

2026-07-04T11:14:04+00:00

Most places we need to parse an integer encoded as a string, we use
strtol() or strtoul().  These already work a bit like descent parser
helpers, in that they consume as much as they can, but don't require the
number parsed to be the whole of the einput string.  Make a wrapper to
parse unsigned integers as part of our parsing helper.  This wrapper
handles the mildly fiddly error checking requirements for strtoul().

We replace a number, though not all, of our existing strtoul() uses with
the new parse_unsigned().  We also replace a number of strtol() use cases,
because, despite using that instead of strtoul() they are only used for
non-negative values.  In some cases this makes the logic a little more
straightforward.  In some other cases it will catch some error cases we
previously could have missed.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

parse: Start splitting out parsing helpers

2026-07-04T11:13:56+00:00

As we add more complexity to what forwarding rules are allowed, our
existing ad-hoc C parsing is starting to become quite awkward.  We already
have some parts that resemble a very simple recursive[0] descent parser,
with composable subfunctions that consume as much input as they need,
rather than pre-splitting based on known delimiters.

Start extending this approach, by creating parse.[ch] with parsing helpers
with a uniform interface.  Initially we start with very simple cases: the
parse_keyword() function from fwd_rule.c and another helper to check that
we've reached the end of input.

Rename parse_keyword() to parse_literal(), because it's not just useful
for "keywords" as such.  We can use it in a bunch of additional places for
parsing delimiters and other symbols.  This doesn't gain us a lot now but
will make things clearer as we use more such parser helpers.

[0] Except that the grammars we have aren't actually recursive, so neither
    is the code.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Add missing PESTO_HEADERS variable

2026-07-04T11:13:50+00:00

In several places we use a PESTO_HEADERS variable, with all the headers
that we need to build the pesto binary.  However, we never define it.
This looks like an error introduced by a bad rebase of the series
introducing pesto before it was merged.

It turns out the fact we didn't list the headers was the only reason we
weren't getting unusedStructMember cppcheck warnings for pesto as we
already do for passt and passt-repair.  So, reinstate that suppression for
pesto as well.

Fixes: 02236db32625 ("pesto: Introduce stub configuration tool")
Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Remove unused DUAL_STACK_SOCKETS define

2026-06-16T21:49:55+00:00

We have a make variable DUAL_STACK_SOCKETS which used to determine whether
we'd use dual stack sockets.  When we introduced it we were concerned that
we might have future ports to systems which did not support them.

We've since discovered that the dual stack interface is described in
RFC 3493, and supported by both Windows and BSD.  Platforms sometimes
differ in the default setting for the IPV6_V6ONLY socket option, but the
feature itself is widely supported.  So, since b8d4fac6a2e7 ("util, pif:
Replace sock_l4() with pif_sock_l4()") we've simply assumed its presence.

The makefile still defines the now unused variable, though.  Remove it.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

cppcheck: Remove unused CPPCHECK_6936

2026-06-16T21:49:24+00:00

Our flags for cppcheck include -D CPPCHECK_6936.  This used to enable a
workaround for a cppcheck bug, but the code where we used it went away
in commit 9153aca15bc1.  Remove the now unused flag.

Fixes: 9153aca15bc1 ("util: Add abort_with_msg() and ASSERT_WITH_MSG() helpers")
Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Remove misleading comments on BASE_*FLAGS

2026-05-26T10:15:44+00:00

I added these comments attempting to describe the difference between
BASE_CFLAGS and CFLAGS.  However, the description given isn't really
accurate, and I'm not even sure the concept I'm trying to describe is
coherent.  Just remove it.

Suggested-by: Stefano Brivio 
Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

pesto: Run static checkers on pesto sources

2026-05-16T13:47:11+00:00

Update the Makefile to run both clang-tidy and cppcheck on pesto as well
as on passt and passt-repair.  This requires a couple of secondary
corrections:
  * pesto.c had an inline suppression that is no longer correct now that
    the protocol version has been bumped to 1.  Remove it.
  * We were globally suppressing the unusedStructMember because it
    hit many false positives on both passt and passt-repair.  It doesn't
    in pesto, meaning it instead creates an unusedSuppression warning.
    Apply the suppression as a flag override for passt and passt-repair,
    instead of globally.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

passt-repair: Run static checkers

2026-05-16T13:47:08+00:00

Run the static checkers, cppcheck and clang-tidy on passt-repair as well
as on passt proper.  This shows up handful of remaining minor warnings,
which we correct.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio