passt/Makefile, branch 2026_05_26.038c51e

Makefile: Remove misleading comments on BASE_*FLAGS

2026-05-26T10:15:44+00:00

I added these comments attempting to describe the difference between
BASE_CFLAGS and CFLAGS.  However, the description given isn't really
accurate, and I'm not even sure the concept I'm trying to describe is
coherent.  Just remove it.

Suggested-by: Stefano Brivio 
Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

pesto: Run static checkers on pesto sources

2026-05-16T13:47:11+00:00

Update the Makefile to run both clang-tidy and cppcheck on pesto as well
as on passt and passt-repair.  This requires a couple of secondary
corrections:
  * pesto.c had an inline suppression that is no longer correct now that
    the protocol version has been bumped to 1.  Remove it.
  * We were globally suppressing the unusedStructMember because it
    hit many false positives on both passt and passt-repair.  It doesn't
    in pesto, meaning it instead creates an unusedSuppression warning.
    Apply the suppression as a flag override for passt and passt-repair,
    instead of globally.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

passt-repair: Run static checkers

2026-05-16T13:47:08+00:00

Run the static checkers, cppcheck and clang-tidy on passt-repair as well
as on passt proper.  This shows up handful of remaining minor warnings,
which we correct.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Split static checker targets

2026-05-16T13:47:01+00:00

Currently we have a single 'cppcheck' and 'clang-tidy' target which checks
passt.  However, it doesn't check the additional binaries, qrap and
passt-repair.  In preparation for running the static checkers on those as
well, split the targets into a top-level rule and a pattern rule which we
will be able to reuse.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

cppcheck, clang-tidy: Static checkers don't need non-preprocessor flags

2026-05-16T13:46:59+00:00

Currently we pass all our compiler flags to clang-tidy, except -pie, which
it won't accept.  In fact in order to run the checker, we only need the
preprocessor flags.  Simplify the command line by passing only those.

For cppcheck we already filter out just -D options from the compiler flags.
Simplify this by only passing preprocessor flags, now that we've split
those out into their own variables.  Furthermore, one of cppcheck's
features which we're currently not exploiting is to check multiple / all
preprocessor option combinations in a single pass.  Therefore, pass only
$(BASE_CPPFLAGS), which contains the mandatory options with which we can't
compile at all.

While we're there remove a redundant $^ that slipped in at some point.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Split $(FLAGS) into cpp and cc components

2026-05-16T13:46:17+00:00

The $(FLAGS) variable contains mandatory compiler flags that should not be
overridden.  However, it contains a mixture of flags for the preprocessor
and for the compiler proper.  That's causing some inconvenience for other
Makefile cleanups, so split it into $(BASE_CPPFLAGS) and $(BASE_CFLAGS)
variables.

Signed-off-by: David Gibson 
[sbrivio: Drop trailing space after BASE_CFLAGS assignment for static]
Signed-off-by: Stefano Brivio

Makefile: Add header dependencies for secondary binaries

2026-05-16T13:45:41+00:00

PASST_HEADERS contains all the headers used by passt, which we use in
various dependencies.  However, qrap and passt-repair each use several
headers which we don't have dependencies for.  Add handling for this to the
Makefile.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Remove unhelpful $(HEADERS) variable

2026-05-16T13:45:40+00:00

Confusingly HEADERS is not headers that are shared between our various
binaries.  Rather it's just the (non generated) headers for passt, plus
seccomp.h.  This isn't particularly useful, just open code it in the
handful of places we need it.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Use common binary compilation rule

2026-05-16T13:45:38+00:00

Each of our binaries (passt, passt.avx2, qrap and passt-repair) has a
separate Make rule instructing how to compile it, but they're all basically
identical.  Combine these all into a single pattern rule, just using
different dependencies and variable overrides where necessary.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

Makefile: Make conditional definition of $(BIN) clearer

2026-05-16T13:45:35+00:00

The list of binaries is dependent on the target architecture, because
x86_64 adds the passt.avx2 and pasta.avx2 binaries.  Make this more
obvious by defining BIN in common, then augmenting it in the x86_64
case.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio