passt, branch 2024_08_21.1d6142f

README: pasta is indeed a supported back-end for rootless Docker

2024-08-21T10:05:26+00:00

...https://github.com/moby/moby/issues/48257 just reminded me.

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

util: Don't stop on unrelated values when looking for --fd in close_open_files()

2024-08-21T10:04:53+00:00

Seen with krun: we get a file descriptor via --fd, but we close it and
happily use the same number for TCP files.

The issue is that if we also get other options before --fd, with
arguments, getopt_long() stops parsing them because it sees them as
non-option values.

Use the - modifier at the beginning of optstring (before :, which is
needed to avoid printing errors) instead of +, which means we'll
continue parsing after finding unrelated option values, but
getopt_long() won't reorder them anyway: they'll be passed with option
value '1', which we can ignore.

By the way, we also need to add : after F in the optstring, so that
we're able to parse the option when given as short name as well.

Now that we change the parsing mode between close_open_files() and
conf(), we need to reset optind to 0, not to 1, whenever we call
getopt_long() again in conf(), so that the internal initialisation
of getopt_long() evaluating GNU extensions is re-triggered.

Link: https://github.com/slp/krun/issues/17#issuecomment-2294943828
Fixes: baccfb95ce0e ("conf: Stop parsing options at first non-option argument")
Fixes: 09603cab28f9 ("passt, util: Close any open file that the parent might have leaked")
Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test: Update list of dependencies in README.md

2024-08-21T10:04:30+00:00

Mostly packages we now need to run Podman-based tests.

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

tcp, udp: Allow timerfd_gettime64() and recvmmsg_time64() on arm (armhf)

2024-08-21T10:04:17+00:00

These system calls are needed after the conversion of time_t to 64-bit
types on 32-bit architectures.

Tested by running some transfer tests with passt and pasta on Debian
Bookworm (glibc 2.36) and Trixie (glibc 2.39), running on armv6l.

Suggested-by: Faidon Liambotis 
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078981
Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

util: Provide own version of close_range(), and no-op fallback

2024-08-21T10:03:48+00:00

musl, as of 1.2.5, and glibc < 2.34 don't ship a (trivial)
close_range() implementation. This will probably be added to musl
soon, by the way:
  https://www.openwall.com/lists/musl/2024/08/01/9

Add a weakly-aliased implementation, if it's supported by the kernel.
If it's not supported (< 5.9), use a no-op fallback. Looping over 2^31
file descriptors calling close() on them is probably not a good idea.

Reported-by: lemmi 
Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

udp_flow: Add missing unistd.h include for close()

2024-08-21T10:03:34+00:00

For some reason, this is reported only with musl, and older glibc
versions (2.31, at least).

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test: Duplicate existing recvfrom() valgrind suppression for recv()

2024-08-21T10:03:23+00:00

Some architectures, including i686, actually have a recv() system
call, not just a recvfrom(), and we need to cover the recv() with
MSG_TRUNC into a NULL buffer for them as well.

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test/passt.mbuto: Install sshd-session OpenSSH's split process

2024-08-21T10:03:03+00:00

OpenSSH now ships a per-session binary, sshd-session, with sshd
acting as mere listener. It's typically not found in $PATH, so specify
the whole path at which it's commonly installed in $PROGS.

Link: https://www.openssh.com/releasenotes.html#9.8p1
Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test/passt.mbuto: Run sshd from vsock proxy with absolute path

2024-08-21T10:02:37+00:00

...OpenSSH >= 9.8 otherwise complains that:

  sshd requires execution with an absolute path

Link: https://bugs.gentoo.org/936041
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078429
Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson

test/lib/setup: Transform i686 kernel architecture name into QEMU name (i386)

2024-08-21T10:01:48+00:00

It's qemu-system-i386, but uname -m reports i686. I didn't test i486
and i586.

Signed-off-by: Stefano Brivio 
Reviewed-by: David Gibson