passt, branch 2024_08_06.ee36266

log, passt: Keep printing to stderr when passt is running in foreground

2024-08-06T13:03:48+00:00

There are two cases where we want to stop printing to stderr: if it's
closed, and if pasta spawned a shell (and --debug wasn't given).

But if passt is running in foreground, we currently stop to report any
message, even error messages, once we're ready, as reported by
Laurent, because we set the log_runtime flag, which we use to indicate
we're ready, regardless of whether we're running in foreground or not.

Turn that flag (back) to log_stderr, and set it only when we really
want to stop printing to stderr.

Reported-by: Laurent Vivier 
Fixes: afd9cdc9bb48 ("log, passt: Always print to stderr before initialisation is complete")
Signed-off-by: Stefano Brivio

tcp_splice: Fix side in OUT_WAIT flag setting

2024-08-06T13:03:31+00:00

If the "from" (input) side for a given transfer is 0, and we can't
complete the write right away, what we need to be waiting for is for
output readiness on side 1, not 0, and the other way around as well.

This causes random transfer failures for local TCP connections,
depending if we ever need to wait for output readiness.

Reported-by: Paul Holzinger 
Link: https://github.com/containers/podman/issues/23517
Signed-off-by: Stefano Brivio 
Tested-by: Paul Holzinger

util: Use unsigned (size_t) value for iov length

2024-08-06T13:01:46+00:00

The "correct" type for the length of an IOV is unclear: writev() and
readv() use an int, but sendmsg() and recvmsg() use a size_t.  Using the
unsigned size_t has some advantages, though, and it makes more sense for
the case of write_remainder.  Using size_t throughout here means we don't
have a signed vs. unsigned comparison, and we don't have to deal with
the case of iov_skip_bytes() returning a value which becomes negative
when assigned to an integer.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

udp_flow: move all udp_flow functions to udp_flow.c

2024-08-05T15:38:17+00:00

No code change.

They need to be exported to be available by the vhost-user version of
passt.

Signed-off-by: Laurent Vivier 
Reviewed-by: David Gibson 
Signed-off-by: Stefano Brivio

udp_flow: Remove udp_meta_t from the parameters of udp_flow_from_sock()

2024-08-05T15:37:53+00:00

To be used with the vhost-user version of udp.c, we need to export the
udp_flow functions. To avoid to export udp_meta_t too that is specific
to the socket version of udp.c, don't pass udp_meta_t to it,
but the only needed field, s_in.

Signed-off-by: Laurent Vivier 
Reviewed-by: David Gibson 
Signed-off-by: Stefano Brivio

log: Make logfile_write() private

2024-08-05T13:03:33+00:00

logfile_write() is not used outside log.c, nor should it be.  It should
only be used externall via the general logging functions.  Make it static
in log.c.  To avoid forward declarations this requires moving a bunch of
functions earlier in the file.

Signed-off-by: David Gibson 
Signed-off-by: Stefano Brivio

pasta: Save errno on signal handler entry, restore on return when needed

2024-08-05T13:02:36+00:00

Ed reported this:

  # Error: pasta failed with exit code 1:
  # Couldn't drop cap 3 from bounding set
  # : No child processes

in a Podman CI run with tests being run in parallel. The error message
itself, by the way, is fixed by commit 1cd773081f12 ("log: Drop
newlines in the middle of the perror()-like messages"), but how can we
possibly get ECHILD as failure code for prctl()?

Well, we don't, but if we exit early enough, pasta_child_handler()
might run before we're even done with isolation steps, and it calls
waitid(), which sets errno. We need to restore it before returning
from the signal handler (if we return after calling functions that
might set it), as signal-safety(7) also implies:

       Fetching and setting the value of errno is async-signal-safe
       provided that the signal handler saves errno on entry and
       restores its value before returning.

Eventually, we'll probably need to switch to signalfd(2) the day we
want to implement multithreading, but this will do for the moment.

Reported-by: Ed Santiago 
Link: https://github.com/containers/podman/issues/23478
Signed-off-by: Stefano Brivio 
Reviewed-by: Paul Holzinger 
Reviewed-by: David Gibson

pasta: modify hostname when detaching new namespace

2024-07-30T15:27:43+00:00

When invoking pasta without any arguments, it's difficult
to tell whether we are in the new namespace or not leaving
users a bit confused. This change modifies the host namespace
to add a prefix "pasta-" to make it a bit more obvious.

Signed-off-by: Danish Prakash 
[sbrivio: coding style fixes]
Signed-off-by: Stefano Brivio

Fix typo in README file

2024-07-29T17:02:35+00:00

- remove duplicated 'the' in the 'Services' section

Signed-off-by: AbdAlRahman Gad 
Reviewed-by: David Gibson 
Signed-off-by: Stefano Brivio

fedora/rpkg: List myself as author for changelog entries

2024-07-26T14:40:41+00:00

...instead of the latest author for contrib/fedora.

Signed-off-by: Stefano Brivio